Improve addElementToRects algorithm by checking for duplicate first

6 years ago · 2b92edf737
parent d624560d0d
commit 2b92edf737
1 changed files with 3 additions and 3 deletions
--- a/core/js/get_markers.js
+++ b/core/js/get_markers.js
@ -54,9 +54,9 @@
        let rect;
        for(let i = 0; i < elements.length; i++) {
            rect = getCoords(elements[i]);
-            if(isElementOnScreen(rect)
-               && isElementOnTop(elements[i], rect)
-               && !hasCopy(validRects, rect)){
+            if(!hasCopy(validRects, rect) &&
+               isElementOnScreen(rect) &&
+               isElementOnTop(elements[i], rect)){
                validRects.push(rect);
            }
        }