From 06b6d0433b95e15ec4f6c558ec79e0d89ce1ba47 Mon Sep 17 00:00:00 2001 From: "Mingde (Matthew) Zeng" Date: Fri, 31 Jan 2020 14:55:37 -0500 Subject: [PATCH] Fix edge case when there is only 1 link --- app/pdf-viewer/buffer.py | 2 +- core/js/get_markers.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/pdf-viewer/buffer.py b/app/pdf-viewer/buffer.py index eaa7e33..96b2d74 100755 --- a/app/pdf-viewer/buffer.py +++ b/app/pdf-viewer/buffer.py @@ -547,7 +547,7 @@ class PdfViewerWidget(QWidget): def generate_random_key(self, count): letters = "ASDFHJKLQWEIOP" key_list = [] - key_len = math.ceil(math.log(count) / math.log(len(letters))) + key_len = 1 if count == 1 else math.ceil(math.log(count) / math.log(len(letters))) while count > 0: key = ''.join(random.choices(letters, k=key_len)) if key not in key_list: diff --git a/core/js/get_markers.js b/core/js/get_markers.js index 7adb12e..f0d43a4 100644 --- a/core/js/get_markers.js +++ b/core/js/get_markers.js @@ -65,7 +65,7 @@ function generateKeys(markerContainer) { let letters = ['A', 'S', 'D', 'F', 'H', 'J', 'K', 'L', 'Q', 'W', 'E', 'O', 'P', 'N', 'M', 'X', 'C' ]; let linkNum = markerContainer.children.length; - let keyLen = Math.ceil(Math.log(linkNum)/Math.log(letters.length)); + let keyLen = linkNum == 1 ? 1 : Math.ceil(Math.log(linkNum)/Math.log(letters.length)); let keys = []; while(linkNum > 0) { let k = "";