From e95e8b771fa68427dd2725f94303b2556513250b Mon Sep 17 00:00:00 2001 From: Morty Space Date: Sat, 11 Dec 2021 22:05:17 +0200 Subject: [PATCH] Fixed spread, fixed timestamp params --- README.md | 1 + src/cryptocom/exchange/__init__.py | 2 +- src/cryptocom/exchange/private.py | 8 ++++++-- src/cryptocom/exchange/structs.py | 5 ++++- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 8ebbb75..f561696 100644 --- a/README.md +++ b/README.md @@ -27,6 +27,7 @@ Exchange original API docs: [https://exchange-docs.crypto.com](https://exchange- ### Changelog +- **0.9.4** - fixed spread func, fixed missing params - **0.9.3** - added RPS limiter by @Irishery - **0.9.2** - fixed event loop import level - **0.9.1** - fixed Windows bug with asyncio event loop diff --git a/src/cryptocom/exchange/__init__.py b/src/cryptocom/exchange/__init__.py index 4d94fae..830c059 100644 --- a/src/cryptocom/exchange/__init__.py +++ b/src/cryptocom/exchange/__init__.py @@ -23,4 +23,4 @@ __all__ = [ 'ApiError', 'ApiProvider' ] -__version__ = '0.9.3' +__version__ = '0.9.4' diff --git a/src/cryptocom/exchange/private.py b/src/cryptocom/exchange/private.py index 7328902..46de5c1 100644 --- a/src/cryptocom/exchange/private.py +++ b/src/cryptocom/exchange/private.py @@ -134,12 +134,16 @@ class Account: ] async def get_trades( - self, pair: Pair = None, page: int = 0, - page_size: int = 200) -> List[PrivateTrade]: + self, pair: Pair = None, start_ts: int = None, end_ts: int = None, + page: int = 0, page_size: int = 200) -> List[PrivateTrade]: """Return trades.""" params = {'page_size': page_size, 'page': page} if pair: params['instrument_name'] = pair.name + if start_ts: + params['start_ts'] = int(start_ts) * 1000 + if end_ts: + params['end_ts'] = int(end_ts) * 1000 data = await self.api.post('private/get-trades', {'params': params}) return [ PrivateTrade.create_from_api( diff --git a/src/cryptocom/exchange/structs.py b/src/cryptocom/exchange/structs.py index 705dd4e..e832dd9 100644 --- a/src/cryptocom/exchange/structs.py +++ b/src/cryptocom/exchange/structs.py @@ -162,7 +162,10 @@ class OrderBook: @property def spread(self) -> float: - return round_down(self.sells[0].price / self.buys[0].price - 1, 6) + return round_down( + self.sells[-1].price / self.buys[0].price - 1, + self.pair.price_precision + ) @dataclass