By scanning through the updates row-by-row rather than column-by-column,
a lot of color-changing updates are saved when using a gradient. This
seems to significantly reduce tearing when running Cava through urxvt on
an X11 server.
`setterm` can fail, in which case cava exits with something like:
> setterm: terminal rxvt-unicode-256color does not support --blank
This commit silences the potential error.
`printf` and friends need to do work to parse the "%d" format string
during each call to `mvprintw`, and then more work to convert a
possibly-variable-length integer to a string.
Since we know that 0 <= `f[bar]` % 8 < 8, we can perform the character
conversion ourselves, saving some CPU time (and battery).
Now, the option to configure gradient with more than 2 colors is
supported. To use this, write the following in your config :
gradient = 1
gradient_count = <num>
gradient_color_1 = <col>
gradient_color_2 = <col>
gradient_color_3 = <col>
.
.
.
gradient_color_<num> = <col>
Replace <num> with the number of colors (2 <= colors <= 8), and replace
<col>s with your colors of choice. You must explicitly provide all
colors for the gradient to work, otherwise appropiate errors will be
shown.
Hex colours will be used only if the terminal supports color redefinition,
otherwise default colours will be used.
This means that no error of any kind will be shown to the user in such cases.
**NOTE: This breaks the `b` and `c` keys for cycling through the colors
in ncurses mode.**
Added a new function in cava.c `int validate_color(char
*colourToValidate, int outputMode)` which returns 1 is the colour is
valid, 0 otherwise.
Validation is done to ensure that HTML colours are of the form `#xxxxxx` or a
named ncurses colour is present.
HTML colours are allowed only when output mode is ncurses (ie `om = 1 ||
om = 2`). HTML and named colours can be mixed.
If the output mode is other than ncurses, the old method of setting
`bgcol` and `col` will be used.
Added a function in `terminal_ncurses.c` called `struct cols
parse_color(char *col)` which returns a struct containing:
1. `col`: The ncurses colour number parsed.
2. `R`, `G` and `B`: Integers that represent the R, G and B values
parsed.
The `init_terminal_ncurses()` method now accepts two character pointers
instead of integers. The pointers contain color names (either HTML or
ncurses names) which are then parsed by the parse function defined
above.
Currently there is no check to find if the terminal supports color
redefinition or not. According to the parsed value we decide whether to
perform redefinition or use the predefined ncurses colours.
Ncurses colours 1 and 2 are redefined for foreground and background
respectively. This means that upon exiting, all the occurrences of 1 and
2 would have been redefined. To fix the colours back to the original the
user has to open another terminal.
Number of bars is now automatic (fill up console), but can also be specified.
Bar width is always static, defaults to 3 charachters.
Cleared up usage of the words bands and bars in sourcecode.
Now mostly using bars.
if the config file already exists, the new settings must be added manually.
Tudor Brindus
karlstav
Sandy
Subhranil Mukherjee
Chelovechishko
Ashhar Hasan