Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
point to this delete-on-destroy hack which was added to avoid outliving
the plugin lifetime.
This method is wrong because the returned style is owned by the caller
(QApplication, QProxyStyle, etc) and will cleaned up when those users
are destructed.
REVIEW: 128760
Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
point to this delete-on-destroy hack which was added to avoid outliving
the plugin lifetime.
This method is wrong because the returned style is owned by the caller
(QApplication, QProxyStyle, etc) and will cleaned up when those users
are destructed.
Review: 128760
due to the removal of explicit moc includes the qt4 build broke as the
plugin helpers were multi-defined (not that I knew why). easy way out is
moving Q_EXPORT_PLUGIN2 from the .h to the .cpp as recommended by the qt
docs anyway.
> There should be exactly one occurrence of this macro in the source code
> for a Qt plugin, and it should be used where the implementation is
> written rather than in a header file.
http://build.kde.org/job/breeze_master/82/console
CCMAIL: kfunk@kde.org
Peter Wu
David Edmundson
Harald Sitter
Kevin Funk
Hugo Pereira Da Costa