Summary:
For a mouse users have the precision that if they clicked in an empty
area they want to perform some action.
For touch and tablets that isn't necessarily true.
From Boud in a kwin report: "The drag the window by empty areas is a
nasty one as well, especially when you're using a pen."
Change needs to happen in oxygen too
Test Plan:
Moved window using sidebar of kate with mouse
Couldn't drag it with a pen
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15942
Summary:
D15889 did link those to their Breeze equivalent of the Adwaita icon for resizing Nautilus. Link them to the actual Breeze resize icons instead
Bug: 399194
Reviewers: #breeze, ngraham
Reviewed By: #breeze, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15950
Summary:
When hovering at the window corner in Nautilus an Adwaita curser is shown. Link it to the Breeze equivalent.
BUG: 399194
Test Plan:
Before:
{F6298098}
After:
{F6298099}
Reviewers: #breeze, hpereiradacosta, ngraham, andreask
Reviewed By: #breeze, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15889
Summary:
Will make it possible to have breeze on the flatpak and snap backends
without all of the wallpapers
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15807
It is QtQuick_FOUND, not Qt_Quick_FOUND. This broke all special-casings for QtQuick,
such as "drag on empty area" in QtQuick windows and ComboBox popups.
BUG: 398663
FIXED-IN: 5.14.0
Differential Revision: https://phabricator.kde.org/D15568
Summary:
Since the removal of the heuristics this seems to be very much disliked by many.
As there is now a configuration option, disabling this by default seems like
the best option.
This diff's purpose is mainly to raise this topic for discussion.
Reviewers: #vdg, #plasma, ngraham, abetts, romangg
Reviewed By: #vdg, #plasma, ngraham, abetts, romangg
Subscribers: romangg, mart, abetts, rizzitello, mmustac, broulik, anthonyfieroni, januz, rikmills, anemeth, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10429
Summary: I tested a bit of code with -02 to measure the speed gains of using a std::initializer_list over appending to a temporary and appending to temporary is around 50% slower, so I removed all the code that appened to temporaries for a initializer list in breeze.
Reviewers: #breeze, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, ngraham, zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13591
Summary:
What do say we invert the shade button when it's in a "checked" state, as we do the keep-above button?
The window decoration theme already inverts the keep-above button's colors when its state is activated, as a "loud" visual cue. The shade button similarly has an active state to indicate, but lacks such a loud cue to help avoid confusion. Depending on a user's other settings, there may be little or no visual indication (other than the nice but modest flip of the button) that a shaded window decoration doesn't belong to the window seen below it.
I'm attaching two screenshots of this patch applied, with a konsole window in both keep-above and shade states, directly over another window's titlebar.
{F6141905}
{F6141930}
Reviewers: #breeze, ngraham, #vdg
Reviewed By: #breeze, ngraham, #vdg
Subscribers: ngraham, plasma-devel
Tags: #plasma, #breeze
Differential Revision: https://phabricator.kde.org/D14389
Summary:
libbreezecommon is not meant to be used outside of breeze (it can't, no headers
are installed) so the .so link is not necessary.
Additionally, rename libbreezecommon.so.5 to libbreezecommon5.so.5 for symmetry
with libbreezecommon4.so.5.
Test Plan: Built and installed it - still works.
Reviewers: #breeze, zzag
Reviewed By: zzag
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D14599
Summary: Currently Breeze hard-depends on QtQuick in order to provide QtQuick-specific theme tweaks, but only for KDE5. This patch decouples KDE4 support from QtQuick support and allows Breeze to be built even when QtQuick is not available (at the loss of the QtQuick specific tweaks of course).
Reviewers: mart
Reviewed By: mart
Subscribers: ngraham, davidedmundson, plasma-devel
Tags: #plasma, #breeze
Differential Revision: https://phabricator.kde.org/D12708
Summary:
Refine shadows in order to match decoration shadows. See D11069
The refined KStyle shadows(from Small to Very Large)
{F5754393, layout=center, size=full}
Desktop experience with the refined shadows
{F5754394, layout=center, size=full}
Depends on D11198
Reviewers: #breeze, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: abetts, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11175
Summary:
5.12 release introduced new decoration shadows. These new shadows are
bigger, centered, and they try to solve a problem related to depth.
Yet, there are still some problems:
* new(5.12) shadows are hard.
* lighting model is broken. Because 5.12 shadows have been centered and
made bigger, they should be casted from north.
This change refines how decoration shadows look:
* shadows are casted from north(shadow under window is bigger and darker,
side shadows are smaller, etc);
* shadows are made up of several separate shadows(one for overall shape,
another for contrast). The separate shadows are produced by using box
shadow helper(something similar to CSS box-shadow property, except there are
no inset and spread properties);
* shadow sizes(e.g. Small, Medium, and so on) haven't changed.
Because GPUs can't be used for blurring images(in our case), the box shadow
helper is using CPU to blur images. More precisely, when blur radius is < 64,
images are blurred with "separable convolutions", otherwise, images are blurred
with a two-dimensional Fourier Transform.
{F5754389, layout=center, size=full}
Desktop experience with the refined shadows
{F5754390, layout=center, size=full}
Depends on D11198
Reviewers: #breeze, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11069
Summary:
Box shadow helper is a helper which draws box shadows, similar to CSS box-shadow property. The only thing it's missing is the spread property but we don't need it pretty much.
Demo
Let's draw a box shadow for the rect QRect(300, 200, 200, 200) with the following params:
* blur radius: 96
* vertical offset: 50
* color: black
```lang=cpp
Breeze::BoxShadowHelper::boxShadow(
&painter,
QRect(300, 200, 200, 200),
QPoint(0, 50),
96,
QColor(0, 0, 0));
```
// the size of the canvas is QSize(800, 600) //
{F5754369, layout=center, size=full}
Reviewers: #breeze, #vdg, hpereiradacosta
Reviewed By: #vdg, hpereiradacosta
Subscribers: ngraham, broulik, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11198
Summary:
D11566 is now in KDE Frameworks 5.45 so we can drop
QStyleOptionProgressBarV2.
Reviewers: #breeze, hpereiradacosta, broulik
Reviewed By: hpereiradacosta, broulik
Subscribers: davidedmundson, broulik, ngraham, ltoscano, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D12256
Summary: As discussed and agreed to in {T8707}, turn off the black triangle that's currently drawn by default when windows are drawn with "No Borders"
Test Plan:
- Tested on a new user: no black triangle when KWin's border setting is "No Borders"
- Tested on an existing user who had `DrawSizeGrip=false` in their `breezerc` file: no change
- Tested on an existing user with who had `DrawSizeGrip=false` in their `breezerc` file and then turned it on in System Settings: black triangle appears as expected
- With the black triangle on, reset to default settings: works as expected
Reviewers: #vdg, #breeze, #plasma, abetts, romangg
Reviewed By: #vdg, #plasma, abetts, romangg
Subscribers: hpereiradacosta, romangg, plasma-devel
Tags: #plasma
Maniphest Tasks: T8707
Differential Revision: https://phabricator.kde.org/D13277
l10n daemon script
David Edmundson
Nicolas Fella
Jonathan Riddell
Aleix Pol
Kai Uwe Broulik
Fabian Vogt
Vlad Zagorodniy
Tomaz Canabrava
Andy Kluger
Alexander Schlarb
Ken Vermette
Hugo Pereira Da Costa
Bhushan Shah
Nathaniel Graham