Summary:
as the last part of the new design, try to not have arrows
in the scrollbars by default (just change of default,
all the functionality is there)
Test Plan: default is correctly picked up
Reviewers: #plasma, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3378
Summary:
make scrollbars size configurable with an enum, letting 3
allowed values, small, medium, large preferring it over
letting the user fiddle with pixel values
the default now is a tiny scrollbar.
(that can be done instead if needed)
Test Plan:
tried the 3 different values and checked that it updates
on the fly
Reviewers: #plasma, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: colomar, alex-l, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3210
Summary:
Another change mostly for KWin (Wayland compositor). KWin destroys it's
internal Wayland connection prior to the QStyle getting destroyed. As
the ShadowHelper initialized Wayland objects those would be destroyed
after the connection is destroyed. With latest Wayland library this
would cause a crash.
Thus unpolish is implemented in the style and deletes the ShadowHelper.
KWin can on tear down invoke the unpolish and thus make sure it doesn't
crash.
CCBUG: 372001
Reviewers: #plasma, broulik, hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3240
Summary:
this reintroduces the else removed in 049168b9bb
this broke the animations for arrows, it made them
appear and disappear again
Test Plan: animation for arrows works again
Reviewers: #plasma, hpereiradacosta
Reviewed By: hpereiradacosta
Differential Revision: https://phabricator.kde.org/D3248
Summary:
This is a change mostly for KWin (the Wayland compositor). The internal
Wayland connection is created after the QStyle is created in the case of
KWin. But both are created before the event dispatcher is run for the
first time. So delaying by one cycle makes it work for KWin and also all
other Wayland applications.
BUG: 372001
FIXED-IN: 5.8.4
Reviewers: #plasma, broulik, hpereiradacosta
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3239
Summary:
When the size of the combo box adjusts to its contents, the dropdown
listbox isn't large enough to fit the contents and a vertical scrollbar
so instead of using Metrics::MenuButton_IndicatorWidth. I defined
a new Metrics::ComboBox_IndicatorWidth which is two pixels larger than
Metrics::MenuButton_IndicatorWidth.
To test this I used "kcmshell5 kcm_kscreen -style breeze" and opened
the resolutions QComboBox (If there are less than 15 possible
resolutions, a slider will appear instead of a QComboBox, so in that
case it's possible to use a virtual machine with QXL video that for
me shows plenty of possible resolutions).
Before this patch, most of the larger resolutions are shortened to
something like "192...200" or "160...200" and can't be read (in the
dropdown listbox, when selected they can be read correctly in the
closed combobox), after applying this patch, all the contents of the
listbox can be read correctly.
Reviewers: #plasma, #plasma:_design, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: hpereiradacosta, davidedmundson, plasma-devel
Tags: #plasma, #plasma:_design
Differential Revision: https://phabricator.kde.org/D3192
Summary:
When the size of the combo box adjusts to its contents, the dropdown
listbox isn't large enough to fit the contents and a vertical scrollbar
so instead of using Metrics::MenuButton_IndicatorWidth. I defined
a new Metrics::ComboBox_IndicatorWidth which is two pixels larger than
Metrics::MenuButton_IndicatorWidth.
To test this I used "kcmshell5 kcm_kscreen -style breeze" and opened
the resolutions QComboBox (If there are less than 15 possible
resolutions, a slider will appear instead of a QComboBox, so in that
case it's possible to use a virtual machine with QXL video that for
me shows plenty of possible resolutions).
Before this patch, most of the larger resolutions are shortened to
something like "192...200" or "160...200" and can't be read (in the
dropdown listbox, when selected they can be read correctly in the
closed combobox), after applying this patch, all the contents of the
listbox can be read correctly.
Reviewers: #plasma, #plasma:_design, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: hpereiradacosta, davidedmundson, plasma-devel
Tags: #plasma, #plasma:_design
Differential Revision: https://phabricator.kde.org/D3192
Summary:
This is a proof of conceptof lighter scrollbars, according to
ideas from the VDG:
show only a tiny placeholder normally, and show the full scrollbar
only on mouse over.
Test Plan:
tested on few applications but i know well the
code is just an early hacky proof of concept,
so i'll redesign it as requested.
being a big visible thing, it will probably need
an option as well to make it behave as it used to.
in action https://www.youtube.com/watch?v=O72qxQHjHcw
Reviewers: #plasma, #breeze, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: plasma-devel, abetts
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D3131
Summary:
So far breeze hard disabled the window moving on Wayland. With this
change the required functionality gets added.
For that Breeze creates an additional Seat and a Pointer on it to track
all pointer button events on the window. That way the kstyle gets the
latest serial which needs to be passed to the move requests. This is not
available through QtWayland's native interface, thus Breeze needs to
interact with Wayland directly.
When the move is triggered Breeze gets the ShellSurface for the window
and triggers the move on the own Seat object with the tracked serial.
Test Plan: Tested with KWin and Weston, move triggered in both.
Reviewers: #plasma_on_wayland
Subscribers: plasma-devel
Tags: #plasma_on_wayland
Differential Revision: https://phabricator.kde.org/D3019
Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
point to this delete-on-destroy hack which was added to avoid outliving
the plugin lifetime.
This method is wrong because the returned style is owned by the caller
(QApplication, QProxyStyle, etc) and will cleaned up when those users
are destructed.
REVIEW: 128760
Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
point to this delete-on-destroy hack which was added to avoid outliving
the plugin lifetime.
This method is wrong because the returned style is owned by the caller
(QApplication, QProxyStyle, etc) and will cleaned up when those users
are destructed.
Review: 128760
l10n daemon script
Marco Martin
Martin Gräßlin
Hugo Pereira Da Costa
Aleix Pol
Jonathan Riddell
Antonio Larrosa
Peter Wu
Andreas Hartmetz
David Edmundson