Summary:
The comment says this should match the default border setting in Breeze. Unfortunately it already doesn't. This patch makes it match the new border size in {D13481}.
Depends on D13481
Reviewers: #breeze, abetts
Reviewed By: abetts
Subscribers: abetts, plasma-devel
Tags: #plasma
Maniphest Tasks: T8707
Differential Revision: https://phabricator.kde.org/D13278
Summary: The current shadow color is Shade Black, which is also used as the ViewBackground color in Breeze dark. This makes the shadow invisible when 2 windows without borders overlap with touching View areas. It also makes color banding worse on cheap displays. Changing the color to black makes the shadow visible on most backgrounds and slightly improves the look of the shadow on cheap displays.
Test Plan:
Before:{F6621844}
After:{F6621843}
Reviewers: #vdg, ngraham, filipf
Reviewed By: #vdg, ngraham, filipf
Subscribers: filipf, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19124
Summary:
Since the removal of the heuristics this seems to be very much disliked by many.
As there is now a configuration option, disabling this by default seems like
the best option.
This diff's purpose is mainly to raise this topic for discussion.
Reviewers: #vdg, #plasma, ngraham, abetts, romangg
Reviewed By: #vdg, #plasma, ngraham, abetts, romangg
Subscribers: romangg, mart, abetts, rizzitello, mmustac, broulik, anthonyfieroni, januz, rikmills, anemeth, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10429
Summary:
5.12 release introduced new decoration shadows. These new shadows are
bigger, centered, and they try to solve a problem related to depth.
Yet, there are still some problems:
* new(5.12) shadows are hard.
* lighting model is broken. Because 5.12 shadows have been centered and
made bigger, they should be casted from north.
This change refines how decoration shadows look:
* shadows are casted from north(shadow under window is bigger and darker,
side shadows are smaller, etc);
* shadows are made up of several separate shadows(one for overall shape,
another for contrast). The separate shadows are produced by using box
shadow helper(something similar to CSS box-shadow property, except there are
no inset and spread properties);
* shadow sizes(e.g. Small, Medium, and so on) haven't changed.
Because GPUs can't be used for blurring images(in our case), the box shadow
helper is using CPU to blur images. More precisely, when blur radius is < 64,
images are blurred with "separable convolutions", otherwise, images are blurred
with a two-dimensional Fourier Transform.
{F5754389, layout=center, size=full}
Desktop experience with the refined shadows
{F5754390, layout=center, size=full}
Depends on D11198
Reviewers: #breeze, #vdg, hpereiradacosta
Reviewed By: hpereiradacosta
Subscribers: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11069
Summary: As discussed and agreed to in {T8707}, turn off the black triangle that's currently drawn by default when windows are drawn with "No Borders"
Test Plan:
- Tested on a new user: no black triangle when KWin's border setting is "No Borders"
- Tested on an existing user who had `DrawSizeGrip=false` in their `breezerc` file: no change
- Tested on an existing user with who had `DrawSizeGrip=false` in their `breezerc` file and then turned it on in System Settings: black triangle appears as expected
- With the black triangle on, reset to default settings: works as expected
Reviewers: #vdg, #breeze, #plasma, abetts, romangg
Reviewed By: #vdg, #plasma, abetts, romangg
Subscribers: hpereiradacosta, romangg, plasma-devel
Tags: #plasma
Maniphest Tasks: T8707
Differential Revision: https://phabricator.kde.org/D13277
Summary:
This implements the menu shadow changes proposed in D9549; now we use a combobox with five options: None, Small, Medium, Large, and Very Large.
Large is the new default value (64px window shadows, 16px menu/tooltip shadows), and implements what we recently changed the default to. Small is the old default value (16px window shadows, 12px menu/tooltip shadows) for people who preferred that.
I had a massive amount of help from @hpereiradacosta; in fact, probably 75% of these changes are his. It's a shame multiple authorship isn't possible. Hugo, feel free to commandeer the revision if you'd like the credit!
Test Plan:
Tested in KDE Neon. New smaller menu shadows for the default window shadow size:
{F5615780}
New shadow chooser UI, with different options:
None (1px border for windows, menus, and tooltips):
{F5623069}
Small (16px window shadows, 12px menu/tooltip shadows); replicates the the old default value:
{F5623071}
Medium (32px window shadows, 14px menu/tooltip shadows):
{F5623072}
Large (64px window shadows, 16px menu/tooltip shadows); the new default:
{F5623073}
Very Large (96px window shadows, 24px menu/tooltip shadows):
{F5623074}
Upgrade story: since this changes the way shadow size is stored in the breezerc file, users who previously had manually set their shadow size to some arbitrary pixel value will now get the new default Large 64 px shadow size.
Reviewers: #vdg, #breeze, hpereiradacosta, abetts, rkflx
Reviewed By: #vdg, hpereiradacosta, abetts, rkflx
Subscribers: rkflx, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9627
Summary:
FEATURE: 388256
#VDG has decided that shadows should be horizontally centered and bigger. This patch implements those changes in the following way:
- Window and menu shadows are now horizontally centered
- Shadow size increased to the maximum value
- Shadow color changed from pure black to a slightly lighter Breeze standard color: Shade Black
Test Plan:
Tested in KDE Neon. Before:
{F5587393}
After:
{F5587390}
Reviewers: abetts, hpereiradacosta, #vdg, #breeze, alake
Reviewed By: abetts, hpereiradacosta, #vdg
Subscribers: rkflx, zzag, cfeck, januz, rpelorosso, apol, mvourlakos, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D9549
Summary:
Adds a new settings on Breeze theme which allows the user to turn off the title bar separator drawn
{F5437291}
{F5437290}
Rationale behind this patch:
From what I understand, the separator is seen as a design choice so I won't argue over it, not to mention something like this is entirely subjective.
However, I personally dislike the separator, especially on darker windows. The only way to get rid of it is to either make a custom color scheme for each application so the colors match exactly or run a patched version of breeze (which is what I do). Before using my Breeze patched version I searched on the net on how to remove it, which led me to several threads with other users wanting to toggle it off which is why I make this patch public.
Below are screenshots where the separator is especially noticeable and in my non-design-expert opinion kind of distracting. I think it's a positive addition. Looking forward to your opinions on the matter.
{F5437332}
{F5437331}
{F5437330}
{F5437329}
Test Plan:
1. Use default breeze theme
2. Check the enable/disable the new setting
Reviewers: #breeze, #vdg, ngraham, hpereiradacosta
Reviewed By: ngraham
Subscribers: andreaska, abetts, jensreuterberg, broulik, rpelorosso, #breeze, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D8362
Yuri Chornoivan
Nathaniel Graham
Noah Davis
Fabian Vogt
Vlad Zagorodniy
Nathaniel Graham
Emirald Mateli
Hugo Pereira Da Costa