--m_iconSize for standalone buttons can be changed
dynamically based on user or container preferences.
Such an example could be the window buttons applet
that is resizing its buttons based on panel thickness
or when the applet is on the desktop and the user
resizes it. Previous implementation was failing
because even though m_iconSize was set as NULL for
StandAlone buttons, on the first painting m_iconSize
was set based on Button::geometry(). This of course
was failing because the Button::geometry() could change
afterwards and painting was not considering it to
calculate m_iconSize again.
Summary:
Some icons can be recolored. However if the titlebar color is different
compared to the normal color scheme, this can lead to bad contrast.
Test Plan:
Before:{F8201155} {F8201159}
After: {F8201139}{F8201144}
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: kossebau, ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D28330
Summary: Parts of these icons did not line up well with the pixel grid making them seem blurry or faded. This has been fixed.
Test Plan:
Before: {F6672364, size=full}
After: {F6672361, size=full}
Reviewers: #vdg, #breeze, zzag, davidedmundson, ngraham
Reviewed By: #vdg, #breeze, ngraham
Subscribers: zzag, ngraham, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19605
Summary:
--as mentioned at T9899 we are not calling the correct
creator when buttons are created in Standalone mode and
as such animations are disabled when BreezeButton is created
from plasma applets. This patch fixes this and restores
the Standalone behavior mode in order to be identical
with the default one.
Test Plan:
-check that window title bars still work
-check that breeze window buttons in titlebar editor buttons
still work
-check that when buttons are used in a plasma applet
they are animated
Reviewers: #breeze, zzag
Reviewed By: zzag
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16596
Summary: I tested a bit of code with -02 to measure the speed gains of using a std::initializer_list over appending to a temporary and appending to temporary is around 50% slower, so I removed all the code that appened to temporaries for a initializer list in breeze.
Reviewers: #breeze, #plasma, davidedmundson
Reviewed By: #plasma, davidedmundson
Subscribers: davidedmundson, ngraham, zzag, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D13591
Summary:
What do say we invert the shade button when it's in a "checked" state, as we do the keep-above button?
The window decoration theme already inverts the keep-above button's colors when its state is activated, as a "loud" visual cue. The shade button similarly has an active state to indicate, but lacks such a loud cue to help avoid confusion. Depending on a user's other settings, there may be little or no visual indication (other than the nice but modest flip of the button) that a shaded window decoration doesn't belong to the window seen below it.
I'm attaching two screenshots of this patch applied, with a konsole window in both keep-above and shade states, directly over another window's titlebar.
{F6141905}
{F6141930}
Reviewers: #breeze, ngraham, #vdg
Reviewed By: #breeze, ngraham, #vdg
Subscribers: ngraham, plasma-devel
Tags: #plasma, #breeze
Differential Revision: https://phabricator.kde.org/D14389
Summary:
QIcon::pixmap doesn't know anything about the paint device currently
being used so uses qApp->devicePixelRatio.
This works in systemsettings, but not in kwin and we get a standard
resolution pixmap returned.
We can't manually multiply by painter->device->dpr because then system
settings would get scaled twice.
QIcon::paint solves that in a way that won't break should kwin's
qApp->dpr change. Also it's IMHO cleaner as it does the alignment
internally.
BUG: 390639
Test Plan:
System settings look the same
Icon in kwin deco is crisper than before
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10713
Summary:
With both Qt devicePixelRatio > 1 and Qt::AA_UseHighDpiPixmaps set
QIcon.pixmap() will return a bigger image than the size requested, with
the relevant devicePixelRatio set.
This code is trying to center an icon within a bounding rect, (like
QStyle::drawItemPixmap) and so positioning should use normalised pixels,
not actual pixmap pixels.
This affected Systemsettings previews but not kwin.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6763
add horizontal offset for rendering
properly extend horizontal hit area for buttons in maximize mode, padding is preserved, but Fitts law is fullfilled.
add horizontal offset for rendering
properly extend horizontal hit area for buttons in maximize mode, padding is preserved, but Fitts law is fullfilled.
Alexander Lohnau
Volker Krause
Michail Vourlakos
Nate Graham
David Redondo
Marco Martin
Heiko Becker
Laurent Montel
Noah Davis
Kai Uwe Broulik
Tomaz Canabrava
Andy Kluger
Vlad Zagorodniy
David Edmundson
Hugo Pereira Da Costa
Sebastian Kügler