Summary: Improve wording and make texts consistent with others.
Test Plan: Open the Curors KCM and hover over Breeze or Breeze Light.
Reviewers: #plasma, #vdg, ngraham, rooty
Reviewed By: #vdg, ngraham, rooty
Subscribers: ngraham, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D19046
In widgets:
* windowHandle() only works for top level widgets (windows), so we need to first get the actual window() as windowHandle() is always
nullptr for controls like ComboBox
In QtQuick Controls:
* we would just blow up for accessing widget which is null here. Use the QQuickWindow of the QQuickItem, if any. Given how long this
went unnoticed shows that Qt *never* ever had icons working in ComboBoxes in QtQuick...
Differential Revision: https://phabricator.kde.org/D18655
Summary:
Update and improve some old Breeze Dark Look and Feel theme previews (similar to D18681).
{F6584513}
Test Plan: Open the Look and Feel KCM.
Reviewers: #plasma, #vdg, ngraham
Reviewed By: #vdg, ngraham
Subscribers: ngraham, #vdg, plasma-devel, #plasma
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D18682
Summary: For some reason, the centers of the generated PNGs are not the centers of the crosshairs. I had to move the 1x crosshairs down and to the left by 2px, the 1.5x crosshairs by 3px and the 2x crosshairs by 3px (it's more centered than 4px).
Test Plan:
Breeze 1x {F6433512}
Breeze 1.5x {F6433522}
Breeze 2x {F6433523}
Breeze Snow 1x {F6433517}
Breeze Snow 1.5x {F6433525}
Breeze Snow 2x {F6433526}
Reviewers: #vdg, #breeze, #plasma, ngraham
Reviewed By: #vdg, #breeze, ngraham
Subscribers: ngraham, plasma-devel, #plasma, #breeze, #vdg
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D17038
Summary:
The crosshair cursors had barely visible outlines, unlike their companions, so they were almost impossible to distinguish against backgrounds of a similar color. This patch fixes that.
BUG: 400110
FIXED-IN: 5.12.8
Test Plan:
Breeze crosshair against a dark background:
{F6424448}
Breeze Snow crosshair against a light background:
{F6424449}
Reviewers: #breeze, #vdg, #plasma, ngraham
Reviewed By: #breeze, #vdg, ngraham
Subscribers: ndavis, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16861
Summary:
D15889 did link those to their Breeze equivalent of the Adwaita icon for resizing Nautilus. Link them to the actual Breeze resize icons instead
Bug: 399194
Reviewers: #breeze, ngraham
Reviewed By: #breeze, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15950
Summary:
When hovering at the window corner in Nautilus an Adwaita curser is shown. Link it to the Breeze equivalent.
BUG: 399194
Test Plan:
Before:
{F6298098}
After:
{F6298099}
Reviewers: #breeze, hpereiradacosta, ngraham, andreask
Reviewed By: #breeze, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15889
Summary:
--as mentioned at T9899 we are not calling the correct
creator when buttons are created in Standalone mode and
as such animations are disabled when BreezeButton is created
from plasma applets. This patch fixes this and restores
the Standalone behavior mode in order to be identical
with the default one.
Test Plan:
-check that window title bars still work
-check that breeze window buttons in titlebar editor buttons
still work
-check that when buttons are used in a plasma applet
they are animated
Reviewers: #breeze, zzag
Reviewed By: zzag
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16596
Summary: includes were incompatible.
Test Plan: Built it.
Reviewers: #breeze, zzag
Reviewed By: zzag
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D16459
Summary:
Creation of shadows (especially for "Large" and "Very large" sizes) is
a computation expensive task because we have to blur alpha channel of a
shadow texture (which then will be tinted with desired shadow color).
Currently, we use the following approach:
* for blur radius less than 64, use naive 2-pass algorithm;
* for blur radius greater than or equal to 64, use FFT.
Even though the FFT approach is doing its the best, it still takes
impresive amount of time to blur the alpha channel.
What makes things even worse is that while we're blurring the alpha
channel, we're blocking the main thread of KWin (decorations are not
rendered in their own thread). This can result in frame drops (2 or 3
frames, something like that).
So, the only viable alternative is to use an approximation of the Gaussian
blur. As such an approximation, I picked the box blur because it's quite
simple, it's fast, and it takes small amount of iterations to have something
similar to the true Gaussian blur.
In general, there are no big differences between true gaussian shadows
and approximated shadows:
Before:
{F6312610}
After:
{F6312613}
Before:
{F6280935}
After:
{F6312608}
As a win, it takes much less time to generate decoration shadows.
Reviewers: #kwin, #plasma, #breeze, #vdg, ngraham
Reviewed By: #breeze, #vdg, ngraham
Subscribers: cfeck, ngraham, abetts, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D15514
l10n daemon script
Björn Feber
Jonathan Riddell
Kai Uwe Broulik
David Edmundson
Nate Graham
Noah Davis
Nicolas Fella
Vlad Zagorodniy
Michail Vourlakos
Fabian Vogt
Bhushan Shah