Vlad Zagorodniy
f632fdc8c4
modernize: delete redundant void args
...
Summary:
Redundant void args are deleted with clang-tidy.
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html
Reviewers: #breeze, mart
Reviewed By: mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D11636
8 years ago
David Edmundson
c32eb41292
Render application icon at paintdevice DPR
...
Summary:
QIcon::pixmap doesn't know anything about the paint device currently
being used so uses qApp->devicePixelRatio.
This works in systemsettings, but not in kwin and we get a standard
resolution pixmap returned.
We can't manually multiply by painter->device->dpr because then system
settings would get scaled twice.
QIcon::paint solves that in a way that won't break should kwin's
qApp->dpr change. Also it's IMHO cleaner as it does the alignment
internally.
BUG: 390639
Test Plan:
System settings look the same
Icon in kwin deco is crisper than before
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D10713
8 years ago
David Edmundson
e827fa0801
Fix app icon button in window decos with high DPI in previews.
...
Summary:
With both Qt devicePixelRatio > 1 and Qt::AA_UseHighDpiPixmaps set
QIcon.pixmap() will return a bigger image than the size requested, with
the relevant devicePixelRatio set.
This code is trying to center an icon within a bounding rect, (like
QStyle::drawItemPixmap) and so positioning should use normalised pixels,
not actual pixmap pixels.
This affected Systemsettings previews but not kwin.
Reviewers: #plasma, mart
Reviewed By: #plasma, mart
Subscribers: mart, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D6763
9 years ago
Hugo Pereira Da Costa
2c895b303d
fixed close button animation.
10 years ago
Hugo Pereira Da Costa
a6693dfcef
Fixed rendering of "unmaximize" button
11 years ago
Hugo Pereira Da Costa
b3bb047ebd
Removed color settings. They were redundant with DecoratedClient::color(...)
11 years ago
Hugo Pereira Da Costa
4fa7ab51d6
make sure iconSize is valid before rendering
11 years ago
Hugo Pereira Da Costa
9a63b05a24
pass iconSize as button's parameter rather than trying to calculate it from geometry and offset
...
Past calculation was wrong anyway
11 years ago
Sebastian Kügler
176a3b892f
Build on ARM
...
This ended up max'ing a double and a qreal.
11 years ago
Hugo Pereira Da Costa
331f9b6ceb
properly update button's animation duration on reconfiguration
11 years ago
Hugo Pereira Da Costa
d2ccf2df45
overall cleanup to align with oxygen code
11 years ago
Hugo Pereira Da Costa
835e39f80c
add option to draw circle around close button
11 years ago
Hugo Pereira Da Costa
f6425c1392
use 45degrees angles for min/max buttons
11 years ago
Hugo Pereira Da Costa
5548fe9fad
cleanup
11 years ago
Hugo Pereira Da Costa
ab54ffae3c
Fixed foreground color for pressed buttons
11 years ago
Hugo Pereira Da Costa
6bbaa7d9cc
improved pin button
11 years ago
Hugo Pereira Da Costa
99ce485bda
set button's visibility depending on the availability of the corresponding feature
...
CCBUG: 343641
11 years ago
Hugo Pereira Da Costa
b67bb573b2
improved pin button rendering, by rottating it 45 degrees, based on Kver's design
11 years ago
Hugo Pereira Da Costa
a03e5a8f40
cosmetics
11 years ago
Hugo Pereira Da Costa
38e60d2977
fixed pen width for small size buttons
11 years ago
Hugo Pereira Da Costa
a9e2d7f933
experience with smaller pen width for button's glyphs
11 years ago
Hugo Pereira Da Costa
92a882efe6
fixed passing non integer pen width to button glyph rendering
11 years ago
Hugo Pereira Da Costa
8fa5ba480a
removed use of penWidth
11 years ago
Hugo Pereira Da Costa
69afdd3be0
properly adjust menu icon size and positioning, to deal with button's offset in maximized
...
mode.
BUG: 343441
11 years ago
Hugo Pereira Da Costa
fcc2e5dbaf
properly adjust menu icon size and positioning, to deal with button's offset in maximized
...
mode.
BUG: 343441
11 years ago
Hugo Pereira Da Costa
b739256b0d
int -> qreal
...
Sorry !
BUG: 343041
11 years ago
Hugo Pereira Da Costa
fd8f6f22b2
use Flag enumeration to describe button position
...
add horizontal offset for rendering
properly extend horizontal hit area for buttons in maximize mode, padding is preserved, but Fitts law is fullfilled.
11 years ago
Hugo Pereira Da Costa
4a62339a4e
added default geometry in constructor
11 years ago
Hugo Pereira Da Costa
ae15e2efba
also translate 'menu' icon properly to keep proper padding in maximized mode
11 years ago
Hugo Pereira Da Costa
ab80e3880f
Moved buttons geometry handling to Breeze::decoration
...
Do not change size of titlebar when maximizing.
Expend buttons hit area to satisfy Fitts law in maximize mode
BUG: 342824
BUG: 342864
11 years ago
Hugo Pereira Da Costa
2389411364
int -> qreal
...
Sorry !
BUG: 343041
11 years ago
Hugo Pereira Da Costa
b1244feb7c
use Flag enumeration to describe button position
...
add horizontal offset for rendering
properly extend horizontal hit area for buttons in maximize mode, padding is preserved, but Fitts law is fullfilled.
11 years ago
Hugo Pereira Da Costa
95e084f4ca
added default geometry in constructor
11 years ago
Hugo Pereira Da Costa
e0d02a785e
also translate 'menu' icon properly to keep proper padding in maximized mode
11 years ago
Hugo Pereira Da Costa
4dd75758dc
Moved buttons geometry handling to Breeze::decoration
...
Do not change size of titlebar when maximizing.
Expend buttons hit area to satisfy Fitts law in maximize mode
BUG: 342824
BUG: 342864
11 years ago
Hugo Pereira Da Costa
4a2a5c483a
cleanup directory structure
...
removed old breeze decoration svg
11 years ago
Hugo Pereira Da Costa
630ba6062d
implemented application menu button
11 years ago
Hugo Pereira Da Costa
c6da10c15e
implemented context help button
11 years ago
Hugo Pereira Da Costa
adee392530
added some auto
11 years ago
Hugo Pereira Da Costa
2ff32c5435
Moved shared pointer typedef to breeze for larger use
...
Use shared pointer for handling InternalSettings inside decoration
11 years ago
Hugo Pereira Da Costa
77f2667336
fancy in-class initialization :)
11 years ago
Hugo Pereira Da Costa
069be4c25d
also initialize animation and opacity for standalone buttons
...
CCMAIL: mgraesslin@kde.org
11 years ago
Hugo Pereira Da Costa
9280f25d74
added copyright
11 years ago
Hugo Pereira Da Costa
453ad537cb
moved all button rendering to breezebutton, without caching
...
removed breezeimageprovider
adjust painter window to have more spacing around button
11 years ago
Hugo Pereira Da Costa
cfbddc9baa
use NegativeText color from kdeglobals for close button
11 years ago
Hugo Pereira Da Costa
3af38fef9c
Improved rendering of buttons, in sync with breeze style
11 years ago
Hugo Pereira Da Costa
1ad9fc23c0
implemented animations for buttons
11 years ago
Hugo Pereira Da Costa
8a322486e5
increased decoration margins
...
increased button spacing
introduced button size
11 years ago
Hugo Pereira Da Costa
5b091d33cd
formatting
11 years ago
Hugo Pereira Da Costa
aef1bff69e
renamed breezedeco to breezedecoration to be in par with class name
...
fixed vertical positionning of buttons
11 years ago