This color scheme is a misnomer, and does not actually offer higher contrast than other color schemes. In fact its contrast is generally worse. As a result it hurts more than it helps. A true "high contrast mode" would require changes to the QStyle to make UI elements larger or change their borders to actually offer an improvement for people who need higher contrast than what is offered by Breeze and Breeze Dark. Accordingly, let's delete this color scheme and migrate current users to Breeze Dark, which is the shipped theme that looks closest to it, and has *better* contrast in many ways. BUG: 352506 BUG: 442286 FIXED-IN: 5.24wilder-5.24
parent
a348854c91
commit
bb70d9c5a6
6 changed files with 35 additions and 160 deletions
@ -1,3 +1,4 @@ |
||||
add_subdirectory(qtcurvepreset) |
||||
add_subdirectory(kde4breeze) |
||||
add_subdirectory(breezetobreezelight) |
||||
add_subdirectory(breezehighcontrasttobreezedark) |
||||
|
||||
@ -0,0 +1,8 @@ |
||||
find_package(KF5ConfigWidgets ${KF5_MIN_VERSION} REQUIRED) |
||||
|
||||
add_executable(breezehighcontrasttobreezedark main.cpp) |
||||
|
||||
target_link_libraries(breezehighcontrasttobreezedark KF5::ConfigWidgets) |
||||
|
||||
install(TARGETS breezehighcontrasttobreezedark DESTINATION ${KDE_INSTALL_LIBDIR}/kconf_update_bin/) |
||||
install(FILES breezehighcontrasttobreezedark.upd DESTINATION ${KDE_INSTALL_KCONFUPDATEDIR}) |
||||
@ -0,0 +1,3 @@ |
||||
Version=5 |
||||
Id=BreezeHighContrastToBreezeDark |
||||
Script=breezehighcontrasttobreezedark |
||||
@ -0,0 +1,23 @@ |
||||
#include <KColorScheme> |
||||
#include <KConfig> |
||||
#include <KConfigGroup> |
||||
|
||||
#include <QDebug> |
||||
|
||||
int main() |
||||
{ |
||||
KConfig globals("kdeglobals"); |
||||
KConfigGroup general(&globals, "General"); |
||||
if (general.readEntry("ColorScheme") != QLatin1String("BreezeHighContrast")) { |
||||
return 0; |
||||
} |
||||
QString breezeDarkPath = QStandardPaths::locate(QStandardPaths::GenericDataLocation, QStringLiteral("color-schemes/BreezeDark.colors")); |
||||
if (breezeDarkPath.isEmpty()) { |
||||
return 0; |
||||
} |
||||
KConfig breezeDark(breezeDarkPath, KConfig::SimpleConfig); |
||||
for (const auto &group : breezeDark.groupList()) { |
||||
auto destination = KConfigGroup(&globals, group); |
||||
KConfigGroup(&breezeDark, group).copyTo(&destination, KConfig::Notify); |
||||
} |
||||
} |
||||
Loading…
Reference in new issue